From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25575 invoked by alias); 27 May 2011 12:08:38 -0000 Received: (qmail 25563 invoked by uid 22791); 27 May 2011 12:08:36 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 May 2011 12:08:19 +0000 Received: (qmail 30933 invoked from network); 27 May 2011 12:08:18 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 27 May 2011 12:08:18 -0000 From: Pedro Alves To: Marek Polacek Subject: Re: [PATCH] gdb.mi/mi-nonstop.exp: fix racy tests (PR testsuite/12649) Date: Fri, 27 May 2011 12:08:00 -0000 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, Tom Tromey References: <4DD4F3B7.2070003@redhat.com> <4DDF88F9.80406@redhat.com> <4DDF8F00.6030504@redhat.com> In-Reply-To: <4DDF8F00.6030504@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105271308.16230.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00631.txt.bz2 On Friday 27 May 2011 12:46:08, Marek Polacek wrote: > On 05/27/2011 01:20 PM, Marek Polacek wrote: > > On 05/26/2011 06:32 PM, Pedro Alves wrote: > >> This pattern appears in all the MI non-stop tests. It'd be nice > >> to move it to mi-support.exp (ideally in a preparatory patch > >> that just does the factoring/moving, and nothing else.) > > > > I'll do it in a bit. > > On the other hand, what's actually the point of setting the `supported' > variable? The above mentioned pattern for setting the `supported' > variable is to be found in these tests: > > mi-nsthrexec.exp > mi-nonstop-exit.exp > mi-nsintrall.exp > mi-nsmoribund.exp > mi-nonstop.exp > mi-ns-stale-regcache.exp > > But the `supported' variable is never used beyond the "-gdb-show non-stop" > part. What am I missing? Eh, good question. I don't even remember that the ,supported= bit ever existed? Patch to remove all of that is pre-approved. -- Pedro Alves