From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81297-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 334 invoked by alias); 26 May 2011 16:32:24 -0000
Received: (qmail 32571 invoked by uid 22791); 26 May 2011 16:32:22 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 16:32:08 +0000
Received: (qmail 25385 invoked from network); 26 May 2011 16:32:07 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 26 May 2011 16:32:07 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb.mi/mi-nonstop.exp: fix racy tests (PR testsuite/12649)
Date: Thu, 26 May 2011 16:32:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; )
Cc: Tom Tromey <tromey@redhat.com>, Marek Polacek <mpolacek@redhat.com>
References: <4DD4F3B7.2070003@redhat.com> <m34o4h1ldc.fsf@fleche.redhat.com>
In-Reply-To: <m34o4h1ldc.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201105261732.05437.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00608.txt.bz2

> >>>>> "Marek" == Marek Polacek <mpolacek@redhat.com> writes:
> 
> Marek> 2011-05-19  Marek Polacek  <mpolacek@redhat.com>
> Marek>         * gdb.mi/mi-nonstop.exp: Use the send_gdb+gdb_expect or mi_gdb_test
> Marek>         instead of the gdb_test_multiple.
> 
> Marek>  set supported 0
> Marek> -gdb_test_multiple "-gdb-show non-stop" "" {
> Marek> -    -re ".*\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
> Marek> +send_gdb "-gdb-show non-stop\n"
> Marek> +gdb_expect {
> Marek> +    -re "\\^done,value=\"off\",supported=\"(\[^\"\]+)\"\r\n$mi_gdb_prompt$" {
> Marek>  	if { $expect_out(1,string) == "1" } {
> Marek>  	    set supported 1
> Marek>  	}
> Marek>      }
> Marek> +    -re "\\^done,value=\"off\"\r\n$mi_gdb_prompt$" {
> Marek> +    }
> Marek>      -re ".*$mi_gdb_prompt$" {
> Marek> +	fail "-gdb-show non-stop"
> Marek>      }
> Marek>  }

This pattern appears in all the MI non-stop tests.  It'd be nice
to move it to mi-support.exp (ideally in a preparatory patch
that just does the factoring/moving, and nothing else.)

> 
> Marek> -gdb_test_multiple "-exec-interrupt --thread 1" "interrupted" {
> Marek> +send_gdb "-exec-interrupt --thread 1\n"
> Marek> +gdb_expect {
> Marek>      -re "\\^done\r\n$mi_gdb_prompt\\*stopped\[^\r\n\]+\r\n$" {
> Marek>  	pass "interrupted"
> Marek>      }
> Marek>  }

Can you use gdb_mi_expect_interrupt (+mi_gdb_test)?  See mi-nsinterall.exp.

-- 
Pedro Alves