From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81241-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15639 invoked by alias); 24 May 2011 08:51:34 -0000
Received: (qmail 15619 invoked by uid 22791); 24 May 2011 08:51:29 -0000
X-SWARE-Spam-Status: No, hits=-1.2 required=5.0	tests=AWL,BAYES_00,KAM_STOCKGEN,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 May 2011 08:51:16 +0000
Received: (qmail 3024 invoked from network); 24 May 2011 08:51:15 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 24 May 2011 08:51:15 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] Testsuite centralize -DSYMBOL_PREFIX uses
Date: Tue, 24 May 2011 08:51:00 -0000
User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; )
Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
References: <005001cc19e6$fe446750$facd35f0$@muller@ics-cnrs.unistra.fr>
In-Reply-To: <005001cc19e6$fe446750$facd35f0$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201105240951.07933.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00552.txt.bz2

On Tuesday 24 May 2011 08:48:38, Pierre Muller wrote:

> +# gdb_target_symbol_prefix_flags returns a string that can be added
> +# to gdb_compile options to define SYMBOL_PREFIX macro value
> +# symbol_prefix_flags returns a string that can be added
> +# for targets that use underscore as symbol prefix.

> +# The list of targets is incomplete and should be enhanced as
> +# reports about missing targets come in.

This sentence is useless, IMO.

> +# TODO: find out automatically if the target needs this.
> +
> +proc gdb_target_symbol_prefix_flags {} {
> +if { [istarget "*-*-cygwin*"] || [istarget "i?86-*-mingw*"]

Missing indentation.

> +     || [istarget "*-*-msdosdjgpp*"] || [istarget "*-*-go32*"]
> +     || [istarget "arm*-*-wince*"] || [istarget "arm*-*-mingwce*"]} {
> +	return "additional_flags=-DSYMBOL_PREFIX=\"_\""

ARM Windows CE is not underscored.  Is DJGPP/GO32?  bfd/config.bfd
appears to indicate it isn't.  None of the places you touched listed
wince or djgpp, afaics.

> +    } else {
> +	return ""
> +    }
> +}
> +

-- 
Pedro Alves