Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: lgustavo@codesourcery.com
Subject: Re: [PATCH, gdbserver] Scan for existing threads during attachment on Linux
Date: Mon, 23 May 2011 10:51:00 -0000	[thread overview]
Message-ID: <201105231151.29472.pedro@codesourcery.com> (raw)
In-Reply-To: <201105231137.53423.pedro@codesourcery.com>

Sorry, I missed this before.

On Monday 23 May 2011 11:37:53, Pedro Alves wrote:
> > +  /* Mark the threads as stopped.  */
> > +  if (!non_stop)
> > +    for_each_inferior (&all_threads, set_resume_kind_stop);

You don't want to do this to all_threads.  You want to do
this to the threads of PID.  Might as well do it in the
loop you've added, right after attaching to each lwp?

There's a comment in linux_attach_lwp_1 that is now stale:

>	??? If the process already has several threads we leave the other
>	threads running.


Pedro Alves


  reply	other threads:[~2011-05-23 10:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 18:41 Luis Machado
2011-05-23 10:38 ` Pedro Alves
2011-05-23 10:51   ` Pedro Alves [this message]
2011-05-23 15:45   ` Luis Machado
2011-05-23 18:25     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201105231151.29472.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox