From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31266 invoked by alias); 20 May 2011 15:37:36 -0000 Received: (qmail 31158 invoked by uid 22791); 20 May 2011 15:37:36 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 May 2011 15:37:22 +0000 Received: (qmail 15003 invoked from network); 20 May 2011 15:37:21 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 May 2011 15:37:21 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [_Complex test 2/4] _Complex type in varargs.exp Date: Fri, 20 May 2011 15:37:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: Yao Qi , "Joseph S. Myers" References: <4DC401D0.1050500@codesourcery.com> <4DD68727.3040502@codesourcery.com> In-Reply-To: <4DD68727.3040502@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201105201637.19106.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00483.txt.bz2 On Friday 20 May 2011 16:22:15, Yao Qi wrote: > OK, I opened another two PRs for armv7l-unknown-linux-gnueabi and > x86_64-unknown-linux-gnu. KFAIL to different PRs according to the > target. An internal error on x86_64-linux is not KFAIL'ed, because I > failed to KFAIL it after some experiments for some time. Did you try setup_kfail? See below. The way you have things doesn't catch the internal error case because that is matched within gdb_test_multiple itself. You could also check the return of gdb_test_multiple to see if an internal match happened, but that's more complicated than setup_kfail. > x86_64-unknown-linux-gnu: > KFAIL: gdb.base/varargs.exp: print find_max_float_real(4, fc1, fc2, fc3, > fc4) (PRMS: gdb/12790) > KFAIL: gdb.base/varargs.exp: print find_max_double_real(4, dc1, dc2, > dc3, dc4) (PRMS: gdb/12790) > FAIL: gdb.base/varargs.exp: print find_max_long_double_real(4, ldc1, > ldc2, ldc3, ldc4) (GDB internal error) > setup_kfail gdb/12776 "i?86-*-*" setup_kfail gdb/12790 "x86_64-*-*" setup_kfail gdb/12791 "arm*-*-*" set test "print find_max_long_double_real(4, ldc1, ldc2, ldc3, ldc4)" gdb_test_multiple $test $test { -re ".*= 4 \\+ 4 \\* I.*${gdb_prompt} $" { pass $test } } Maybe you can even convert the gdb_test_multiple's to gdb_test that way. (You could also put the setup_kfails in a procedure to not need to repeat them everywhere). -- Pedro Alves