From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81127-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29048 invoked by alias); 19 May 2011 13:38:50 -0000
Received: (qmail 28979 invoked by uid 22791); 19 May 2011 13:38:49 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 13:38:36 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p4JDbF9Y013859;	Thu, 19 May 2011 15:37:15 +0200 (CEST)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p4JDbDRC014896;	Thu, 19 May 2011 15:37:13 +0200 (CEST)
Date: Thu, 19 May 2011 13:38:00 -0000
Message-Id: <201105191337.p4JDbDRC014896@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
CC: gdb-patches@sourceware.org
In-reply-to: <201105191322.p4JDMV26020875@glazunov.sibelius.xs4all.nl>	(message from Mark Kettenis on Thu, 19 May 2011 15:22:32 +0200 (CEST))
Subject: Re: [_Complex test 1/4]  support_complex_tests in gdb.exp and pass _Complex args to func
References: <4DC401D0.1050500@codesourcery.com>	<Pine.LNX.4.64.1105061426440.8538@digraph.polyomino.org.uk>	<4DC75036.4040806@codesourcery.com> <m3oc3bud5j.fsf@fleche.redhat.com> <4DD49BE7.80206@codesourcery.com> <201105190814.p4J8EMYF020774@glazunov.sibelius.xs4all.nl> <4DD514A6.7040606@codesourcery.com> <201105191322.p4JDMV26020875@glazunov.sibelius.xs4all.nl>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-05/txt/msg00438.txt.bz2

> Date: Thu, 19 May 2011 15:22:32 +0200 (CEST)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> 
> > Date: Thu, 19 May 2011 21:01:26 +0800
> > From: Yao Qi <yao@codesourcery.com>
> > 
> > On 05/19/2011 04:14 PM, Mark Kettenis wrote:
> > > The other thing is that the testsuite should not be "conservative".
> > > We should run as many tests as possible on as many platforms as
> > > possible.  Tests that are known to fail should be KFAILed (if there is
> > > a known bug/issue with GDB itself) or XFAILed (if there is an issue
> > > with the platform).  Only if running the tests causes serious problems
> > > (crashing the OS, causing excessive timeouts) we should consider
> > > skipping them.
> > 
> > No.  I don't want to break running non-complex-type tests in
> > funcargs.exp or varargs.exp on platforms that don't support _Complex
> > after this patch.
> 
> Ok, I see what you're trying to avoid now.  In that case you should
> first build the test binary without defining TEST_COMPLEX, run the
> existing tests, rebuild the binary with TEST_COMPLEX and then run the
> new _Complex tests.  Or simply seperate the _Complex tests into files
> of their own.

Of course the feature-based test that Joseph suggested is fine as well.