From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11420 invoked by alias); 19 May 2011 13:24:10 -0000 Received: (qmail 11385 invoked by uid 22791); 19 May 2011 13:24:08 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 13:23:54 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p4JDMXWQ010952; Thu, 19 May 2011 15:22:33 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p4JDMV26020875; Thu, 19 May 2011 15:22:32 +0200 (CEST) Date: Thu, 19 May 2011 13:24:00 -0000 Message-Id: <201105191322.p4JDMV26020875@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: yao@codesourcery.com CC: gdb-patches@sourceware.org In-reply-to: <4DD514A6.7040606@codesourcery.com> (message from Yao Qi on Thu, 19 May 2011 21:01:26 +0800) Subject: Re: [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func References: <4DC401D0.1050500@codesourcery.com> <4DC75036.4040806@codesourcery.com> <4DD49BE7.80206@codesourcery.com> <201105190814.p4J8EMYF020774@glazunov.sibelius.xs4all.nl> <4DD514A6.7040606@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00436.txt.bz2 > Date: Thu, 19 May 2011 21:01:26 +0800 > From: Yao Qi > > On 05/19/2011 04:14 PM, Mark Kettenis wrote: > > The other thing is that the testsuite should not be "conservative". > > We should run as many tests as possible on as many platforms as > > possible. Tests that are known to fail should be KFAILed (if there is > > a known bug/issue with GDB itself) or XFAILed (if there is an issue > > with the platform). Only if running the tests causes serious problems > > (crashing the OS, causing excessive timeouts) we should consider > > skipping them. > > No. I don't want to break running non-complex-type tests in > funcargs.exp or varargs.exp on platforms that don't support _Complex > after this patch. Ok, I see what you're trying to avoid now. In that case you should first build the test binary without defining TEST_COMPLEX, run the existing tests, rebuild the binary with TEST_COMPLEX and then run the new _Complex tests. Or simply seperate the _Complex tests into files of their own.