From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19938 invoked by alias); 19 May 2011 09:59:21 -0000 Received: (qmail 19927 invoked by uid 22791); 19 May 2011 09:59:20 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,TW_FC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 09:59:05 +0000 Received: (qmail 13572 invoked from network); 19 May 2011 09:59:04 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 May 2011 09:59:04 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [OB] Fix xcoffread.c build error Date: Thu, 19 May 2011 09:59:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: Hui Zhu References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105191059.02173.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00429.txt.bz2 On Thursday 19 May 2011 07:56:00, Hui Zhu wrote: > gcc -g -O2 -I. -I../../src/gdb -I../../src/gdb/common > -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" > -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode > -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd > -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber > -I../../src/gdb/../libdecnumber -I../../src/gdb/gnulib -Ignulib > -DMI_OUT=1 -DTUI=1 -DGDBTK -Wall -Wdeclaration-after-statement > -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused > -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts > -Werror -c -o xcoffread.o -MT xcoffread.o -MMD -MP -MF > .deps/xcoffread.Tpo ../../src/gdb/xcoffread.c > cc1: warnings being treated as errors > ../../src/gdb/xcoffread.c: In function 'xcoff_psymtab_to_symtab_1': > ../../src/gdb/xcoffread.c:964:25: error: > 'fcn_aux_saved$x_sym$x_misc$x_fsize' may be used uninitialized in this > function > make[2]: *** [xcoffread.o] Error 1 > make[2]: Leaving directory `/home/teawater/gdb/cvs/ba/gdb' > make[1]: *** [all-gdb] Error 2 > make[1]: Leaving directory `/home/teawater/gdb/cvs/ba' > make: *** [all] Error 2 > > 2011-05-19 Hui Zhu > > * xcoffread.c (read_xcoff_symtab): Initialize fcn_aux_saved. > =================================================================== > RCS file: /cvs/src/src/gdb/xcoffread.c,v > retrieving revision 1.87 > retrieving revision 1.88 > diff -u -r1.87 -r1.88 > --- src/gdb/xcoffread.c 2011/04/19 14:33:09 1.87 > +++ src/gdb/xcoffread.c 2011/05/19 06:54:30 1.88 > @@ -961,7 +961,7 @@ > struct coff_symbol fcn_stab_saved = { 0 }; > > /* fcn_cs_saved is global because process_xcoff_symbol needs it. */ > - union internal_auxent fcn_aux_saved; > + union internal_auxent fcn_aux_saved = main_aux; Hmm? Initializing fcn_aux_saved with the also uninitialized main_aux makes the warning go away? This appears to be hiding a real bug. > struct context_stack *new; > > char *filestring = " _start_ "; /* Name of the current file. */ > -- Pedro Alves