Re: [_Complex test 4/4 V3] _Complex tests in callfuncs.exp

Mark Kettenis
2011-05-24T10:00:35Z

> Date: Tue, 24 May 2011 17:34:15 +0800
> From: Yao Qi <yao@codesourcery.com>
>
> On 05/24/2011 04:59 PM, Mark Kettenis wrote:
> >> > This is the version 3 of patch 4/4. In this version,
> >> > setup_kfail_for_target is used to KFAIL the same fail to different PRs
> >> > according to target triplet, same as what I did in patch 3/4.
> > Can't you fold this behaviour into the normal setup_kfail?
>
> I don't want to propagate this changes to setup_kfail in DejaGnu,
> because I don't know how setup_kfail is used elsewhere. It is better to
> keep setup_kfail_for_target local in GDB, IMO.

Ah, I didn't realize that setup_kfail was part of dejagnu proper.
Still I think that setup_kfail_for_target is what the behaviour of
setup_kfail should be. So dejagnu should be changed.

I'd say you should just go with your previous version that uses
setup_kfail, and submit the enhancement of setup_kfail to the dejagnu
maintainers. I believe you can link together bugs in bugzilla, so in
the interim, you could use that feature to link together the various
bug reports such that people can find the right one even if the bug ID
that gets printed is the wrong one.

Anyway, getting these tests in is more important than getting the
linking to bug reports exactly right. If other people think that
setup_kfail_for_target is the way to go, feel free to ignore me.