From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17370 invoked by alias); 17 May 2011 13:31:15 -0000 Received: (qmail 17358 invoked by uid 22791); 17 May 2011 13:31:13 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 May 2011 13:30:54 +0000 Received: (qmail 21020 invoked from network); 17 May 2011 13:30:53 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 17 May 2011 13:30:53 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [DOC/RFA] point stub implementers towards the vCont packet Date: Tue, 17 May 2011 13:31:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: Eli Zaretskii References: <201105171338.49226.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201105171430.51277.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00377.txt.bz2 On Tuesday 17 May 2011 14:21:04, Eli Zaretskii wrote: > > From: Pedro Alves > > +At a minimum, a stub is required to support the @samp{g}, @samp{G} > > "the @samp{g} and @samp{G} commands" is better. Indeed. > > +(step) @var{command}s. Stubs that support multi-threading targets > > +should support the @samp{vCont} command. All other @var{command}s are > > optional. > > There's no need to use @var here, as you use "command" as a literal > word, and the relation to @var{command} in the packet being documented > is clear. I agree, even though that's preexisting. Applied with those changes, as below. Thanks. -- Pedro Alves 2011-05-17 Pedro Alves gdb/doc/ * gdb.texinfo (Remote Protocol) : Mention vCont is required for multi-threading support. (Remote Protocol) : Mention that 'c', 's', 'C', 'S' and Hc are deprecated for multi-threading debugging. Point readers at the vCont packet. --- gdb/doc/gdb.texinfo | 34 ++++++++++++++++++++++++++-------- 1 file changed, 26 insertions(+), 8 deletions(-) Index: src/gdb/doc/gdb.texinfo =================================================================== --- src.orig/gdb/doc/gdb.texinfo 2011-05-16 13:32:33.000000000 +0100 +++ src/gdb/doc/gdb.texinfo 2011-05-17 14:24:46.653489004 +0100 @@ -32195,9 +32195,12 @@ For any @var{command} not supported by t protocol. A newer @value{GDBN} can tell if a packet is supported based on that response. -A stub is required to support the @samp{g}, @samp{G}, @samp{m}, @samp{M}, -@samp{c}, and @samp{s} @var{command}s. All other @var{command}s are -optional. +At a minimum, a stub is required to support the @samp{g} and @samp{G} +commands for register access, and the @samp{m} and @samp{M} commands +for memory access. Stubs that only control single-threaded targets +can implement run control with the @samp{c} (continue), and @samp{s} +(step) commands. Stubs that support multi-threading targets should +support the @samp{vCont} command. All other commands are optional. @node Packets @section Packets @@ -32334,6 +32337,9 @@ Reply: Continue. @var{addr} is address to resume. If @var{addr} is omitted, resume at current address. +This packet is deprecated for multi-threading support. @xref{vCont +packet}. + Reply: @xref{Stop Reply Packets}, for the reply specifications. @@ -32342,6 +32348,9 @@ Reply: Continue with signal @var{sig} (hex signal number). If @samp{;@var{addr}} is omitted, resume at same address. +This packet is deprecated for multi-threading support. @xref{vCont +packet}. + Reply: @xref{Stop Reply Packets}, for the reply specifications. @@ -32424,13 +32433,15 @@ for success for an error @end table -@item H @var{c} @var{thread-id} +@item H @var{op} @var{thread-id} @cindex @samp{H} packet Set thread for subsequent operations (@samp{m}, @samp{M}, @samp{g}, -@samp{G}, et.al.). @var{c} depends on the operation to be performed: it -should be @samp{c} for step and continue operations, @samp{g} for other -operations. The thread designator @var{thread-id} has the format and -interpretation described in @ref{thread-id syntax}. +@samp{G}, et.al.). @var{op} depends on the operation to be performed: +it should be @samp{c} for step and continue operations (note that this +is deprecated, supporting the @samp{vCont} command is a better +option), @samp{g} for other operations. The thread designator +@var{thread-id} has the format and interpretation described in +@ref{thread-id syntax}. Reply: @table @samp @@ -32570,6 +32581,9 @@ The @samp{R} packet has no reply. Single step. @var{addr} is the address at which to resume. If @var{addr} is omitted, resume at same address. +This packet is deprecated for multi-threading support. @xref{vCont +packet}. + Reply: @xref{Stop Reply Packets}, for the reply specifications. @@ -32579,6 +32593,9 @@ Reply: Step with signal. This is analogous to the @samp{C} packet, but requests a single-step, rather than a normal resumption of execution. +This packet is deprecated for multi-threading support. @xref{vCont +packet}. + Reply: @xref{Stop Reply Packets}, for the reply specifications. @@ -32635,6 +32652,7 @@ for success in non-stop mode (@pxref{Rem @item vCont@r{[};@var{action}@r{[}:@var{thread-id}@r{]]}@dots{} @cindex @samp{vCont} packet +@anchor{vCont packet} Resume the inferior, specifying different actions for each thread. If an action is specified with no @var{thread-id}, then it is applied to any threads that don't have a specific action specified; if no default action is