From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3746 invoked by alias); 14 May 2011 17:12:25 -0000 Received: (qmail 3737 invoked by uid 22791); 14 May 2011 17:12:25 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 14 May 2011 17:12:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 80E562BB2E7; Sat, 14 May 2011 13:12:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NpS3BufDJyo0; Sat, 14 May 2011 13:12:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 542CD2BB2E1; Sat, 14 May 2011 13:12:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3E884145615; Sat, 14 May 2011 10:12:04 -0700 (PDT) Date: Sat, 14 May 2011 17:12:00 -0000 From: Joel Brobecker To: Hui Zhu Cc: gdb-patches ml Subject: Re: [OB] Fix build error in ui-file.c Message-ID: <20110514171204.GE19356@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00342.txt.bz2 > Fix it like others in this file. > > 2011-05-14 Hui Zhu > > * ui-file.c (stdio_file_write_async_safe): Add empty check for build. Personally, I think we're just sweeping the problem under the rug. I'd rather have something like this: > - write (stdio->fd, buf, length_buf); > + if (write (stdio->fd, buf, length_buf)) > + ; if (write (stdio->fd, buf, length_buf) < 0) /* Ignore this error *because*... */; -- Joel