Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch 0/3] readline-6.2 rebase
Date: Wed, 11 May 2011 17:15:00 -0000	[thread overview]
Message-ID: <20110511171441.GA4224@host1.jankratochvil.net> (raw)
In-Reply-To: <20110511163623.GB19356@adacore.com>

On Wed, 11 May 2011 18:36:23 +0200, Joel Brobecker wrote:
> I'm sensitive to the 'git bisect' argument, and I think that it's easy
> to recreate the local diff. Also, I think we've always submitted the
> vast majority of changes we make to readline, so of the changes should
> no longer be needed at the next update. So a single-commit would be
> my prefered option.

OK, I will go with this single-commit way.


> But I don't have a strong opinion. A multi-commit would be fine as well.
> Or we could cut the cake in the middle, and make 2 commits: one resetting
> readline with no change, and then one commit with all our local changes.

TBH the two-commit way seems to me to have only disadvantages of both ways.


Thanks,
Jan


  reply	other threads:[~2011-05-11 17:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-01 12:29 Jan Kratochvil
2011-05-09 17:00 ` Tom Tromey
2011-05-11  6:04   ` Jan Kratochvil
2011-05-11 16:36     ` Joel Brobecker
2011-05-11 17:15       ` Jan Kratochvil [this message]
2011-05-11 23:44 ` [commit] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110511171441.GA4224@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox