From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1536 invoked by alias); 11 May 2011 09:14:17 -0000 Received: (qmail 1526 invoked by uid 22791); 11 May 2011 09:14:16 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 May 2011 09:14:01 +0000 Received: (qmail 31208 invoked from network); 11 May 2011 09:14:00 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 May 2011 09:14:00 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH] Support for enabling/disabling tracepoints while a trace experiment is running Date: Wed, 11 May 2011 09:14:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: Kwok Cheung Yeung , Eli Zaretskii References: <4DC2DDEF.10600@codesourcery.com> <8339ksm85f.fsf@gnu.org> <4DC840FE.6050408@codesourcery.com> In-Reply-To: <4DC840FE.6050408@codesourcery.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201105111014.07919.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00278.txt.bz2 On Monday 09 May 2011 20:31:10, Kwok Cheung Yeung wrote: > gdb/ > * breakpoint.c (disable_breakpoint): Disable all locations > associated with a tracepoint on target if a trace experiment is > running. > (disable_command): Disable a specific tracepoint location on target if > a trace experiment is running. > (do_enable_breakpoint): Enable all locations associated with a > tracepoint on target if a trace experiment is running. > (enable_command) Enable a specific tracepoint location on target if a > trace experiment is running. > * target.c (update_current_target): Add INHERIT and de_fault clauses for > to_supports_enable_disable_tracepoint, to_enable_tracepoint and > to_disable_tracepoint. > * target.h: Add declaration of struct bp_location. > (struct target_ops): Add new functions > to_supports_enable_disable_tracepoint, to_enable_tracepoint and > to_disable_tracepoint to target operations. > (target_supports_enable_disable_tracepoint): New macro. > (target_enable_tracepoint): New macro. > (target_disable_tracepoint): New macro. > * remote.c (struct remote_state): Add new field. > (remote_enable_disable_tracepoint_feature): New. > (remote_protocol_features): Add new entry. > (remote_supports_enable_disable_tracepoint): New. > (remote_enable_tracepoint): New. > (remote_disable_tracepoint): New. > (init_remote_ops): Add remote_enable_tracepoint, > remote_disable_tracepoint and remote_supports_enable_disable_tracepoint > to remote operations. > * tracepoint.c (start_tracing): Allow tracing to start without any > tracepoints enabled with just a warning if they can be re-enabled > later. Okay. > > gdb/gdbserver/ > * server.c (handle_query): Add EnableDisableTracepoints to the list > of supported features. > * tracepoint.c (clear_installed_tracepoints): Uninstall disabled > tracepoints. > (cmd_qtenable_disable): New. > (cmd_qtstart): Install tracepoints even if disabled. > (handle_tracepoint_general_set): Add call to cmd_qtenable_disable on > receiving a QTEnable or QTDisable packet. > (gdb_collect): Skip data collection if fast tracepoint is disabled. > (ust_marker_to_static_tracepoint): Do not ignore disabled static > tracepoints. > (gdb_probe): Skip data collection if static tracepoint is disabled. Okay. -- Pedro Alves