From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17082 invoked by alias); 4 May 2011 14:52:52 -0000 Received: (qmail 17074 invoked by uid 22791); 4 May 2011 14:52:50 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 May 2011 14:52:35 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 93990CB0248; Wed, 4 May 2011 16:52:34 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ikRYY3uNNTMS; Wed, 4 May 2011 16:52:31 +0200 (CEST) Received: from province.act-europe.fr (province.act-europe.fr [10.10.0.214]) by mel.act-europe.fr (Postfix) with ESMTP id 99B7CCB0214; Wed, 4 May 2011 16:52:31 +0200 (CEST) Received: by province.act-europe.fr (Postfix, from userid 560) id 6553F16480A; Wed, 4 May 2011 16:52:31 +0200 (CEST) Date: Wed, 04 May 2011 14:52:00 -0000 From: Jerome Guitton To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Support for x86 on-stack trampolines Message-ID: <20110504145231.GA64873@adacore.com> References: <1304468424-2060-1-git-send-email-guitton@adacore.com> <201105040955.27810.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201105040955.27810.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-11-01) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00094.txt.bz2 Pedro Alves (pedro@codesourcery.com): > default_frame_unwind_stop_reason is only used by > archs/targets that don't support tracepoints at the moment. > It shouldn't be used in any x86-specific unwinder. > > If you reuse the this _frame_this_id method of the > epilogue unwinder, you should reuse the _unwind_stop_reason > method of the same unwinder, since you're effectively > also reusing i386_epilogue_frame_cache. Definitely. Thank you for catching that.