From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23338 invoked by alias); 2 May 2011 17:21:19 -0000 Received: (qmail 23325 invoked by uid 22791); 2 May 2011 17:21:18 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 May 2011 17:21:04 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p42HKgkl006162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 May 2011 13:20:42 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p42HKefH014122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 2 May 2011 13:20:42 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p42HKeJQ003345; Mon, 2 May 2011 19:20:40 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p42HKds1003332; Mon, 2 May 2011 19:20:39 +0200 Date: Mon, 02 May 2011 17:21:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Marek Polacek , Joel Brobecker Subject: Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649) Message-ID: <20110502172039.GA3292@host1.jankratochvil.net> References: <4DB82F26.30801@redhat.com> <201105021709.51088.pedro@codesourcery.com> <20110502163418.GA30891@host1.jankratochvil.net> <201105021754.35146.pedro@codesourcery.com> <20110502170338.GA1976@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110502170338.GA1976@host1.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00031.txt.bz2 On Mon, 02 May 2011 19:03:38 +0200, Jan Kratochvil wrote: > GDB complete_command also obviously leads to complete_line. But it does not emulate _rl_find_completion_word perfectly: /* complete_line assumes that its first argument is somewhere within, and except for filenames at the beginning of, the word to be completed. The following crude imitation of readline's word-breaking tries to accomodate this. */ > But maybe the coverage equivalance is not so obvious as I considered it. So OK, if you have coded it already and gdb_test "complete ..." is not a perfect replacement I agree it should be kept just with your patch. Thanks, Jan