From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22987 invoked by alias); 2 May 2011 16:20:36 -0000 Received: (qmail 22954 invoked by uid 22791); 2 May 2011 16:20:33 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 May 2011 16:20:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p42GKGFc012045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 2 May 2011 12:20:16 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p42GKEUl024866 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 2 May 2011 12:20:16 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p42GKEq8030875; Mon, 2 May 2011 18:20:14 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p42GKEqs030874; Mon, 2 May 2011 18:20:14 +0200 Date: Mon, 02 May 2011 16:20:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [patch 4/3] readline-6.2: Substitute inc-hist.texinfo Message-ID: <20110502162014.GA28920@host1.jankratochvil.net> References: <20110502141121.GA19958@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00023.txt.bz2 On Mon, 02 May 2011 16:34:51 +0200, Eli Zaretskii wrote: > > --- a/readline/doc/hsuser.texi > > +++ b/readline/doc/hsuser.texi > > @@ -26,9 +26,10 @@ into another language, under the above conditions for modified versions. > > @node Using History Interactively > > @chapter Using History Interactively > > > > -@ifclear BashFeatures > > -@defcodeindex bt > > -@end ifclear > > +@c GDB bundling modification: > > +@c @ifclear BashFeatures > > +@c @defcodeindex bt > > +@c @end ifclear > > Why do we need to comment this out? BTW it was already commented out the same way in readline-5.1. > If BashFeatures is not set, the > @defcodeindex line will not be in effect anyway. Is something setting > BashFeatures anywhere when we build our docs? You are right BashFeatures is not set but this is @ifclear. Therefore: ./../../readline/doc/hsuser.texi:31: Index `bt' already exists. > > This chapter describes how to use the @sc{gnu} History Library interactively, > > from a user's standpoint. It should be considered a user's guide. For > > information on using the @sc{gnu} History Library in your own programs, > > -@pxref{Programming with GNU History}. > > +@c GDB bundling modification: > > +@pxref{Programming with GNU History, , , history, GNU History Library}. > > @end ifclear > > Is this because the referenced node is only in the separate > history.info manual, which is not part of hsuser.texi? Yes: ./../../readline/doc/hsuser.texi:44: Cross reference to nonexistent node `Programming with GNU History' (perhaps incorrect sectioning?). > If so, this is > actually a bug in Readline docs which should be fixed upstream in a > way that allows any project to include hsuser.texi without making such > changes. For example: > > @ifset HsUser > @pxref{Programming with GNU History, , , history, GNU History Library}. > @end ifset > @ifclear HsUser > @pxref{Programming with GNU History}. > @end ifclear > > Then projects that include just hsuser.texi will need to pass the > "-DHsUser" switch to makeinfo, while Readline will not. > > I'm okay with making these changes for now, to allow people building > GDB without failures. But if Chet accepts the above change, we should > switch to it in GDB, so that our doc/Makefile.in is ready for the next > upstream release of Readline. I guess defined BashFeatures was partially meant for some inclusion, OK. Thanks, Jan