From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14235 invoked by alias); 27 Apr 2011 15:05:48 -0000 Received: (qmail 14215 invoked by uid 22791); 27 Apr 2011 15:05:47 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Apr 2011 15:05:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0BC272BB087; Wed, 27 Apr 2011 11:05:33 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lbjzGxWDyX2A; Wed, 27 Apr 2011 11:05:32 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D03A52BAF4B; Wed, 27 Apr 2011 11:05:32 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 91E20145615; Wed, 27 Apr 2011 08:05:29 -0700 (PDT) Date: Wed, 27 Apr 2011 15:05:00 -0000 From: Joel Brobecker To: Marek Polacek Cc: "gdb-patches@sourceware.org" Subject: Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649) Message-ID: <20110427150529.GA2489@adacore.com> References: <4DB82F26.30801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DB82F26.30801@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00508.txt.bz2 > Thus, my point is that we could replace those "send_gdb + sleep + > gdb_expect" sequences with just one gdb_test{,multiple,no_output}. I > don't know yet if this transformation is possible for every test in > the completion.exp file. Maybe the changes would be quite dramatical. > However, this test would be _much_ simpler and much faster. Also, the > current formatting is ugly ;). > > So, do you think this is a good idea? Is there something I'm missing? I don't know the history of the testcase, and this is only my own opinion, but I tend to agree with you. I think we should keep one test with \t, to make sure that a tab does trigger the completion, but the rest of the testcase should be using the "complete" command. That's what we do at AdaCore anyways... -- Joel