On Tuesday, April 26, 2011 20:03:43 Tom Tromey wrote:
> >>>>> "Volodya" == Vladimir Prus <vladimir@codesourcery.com> writes:
> Volodya> The enclosed patch implements MI notifications about breakpoint
> Volodya> changes.  As other MI notifications, those are emitted only
> Volodya> when breakpoint changes by something that is not a MI command
> Volodya> to change a breakpoint. For example, -break-condition will not
> Volodya> cause a breakpoint-changed notification to be emitted.
> 
> Volodya> This functionality was independently written by Tom and myself,
> Volodya> and this patch merges the patches together. As a side effect,
> Volodya> existing breakpoint observers were modified to take a pointer
> Volodya> to breakpoint rather than it, which eliminates quite some
> Volodya> busywork.
> 
> Thanks for doing this.
> 
> A few nits on the code part, nothing serious though.

Thanks for the review. Is this version better?

- Volodya

-- 
Vladimir Prus
Mentor Graphics
+7 (812) 677-68-40