Re: print_npx_status_word

Tom Tromey
2011-04-18T17:04:04Z

>>>>> "Michael" == Baars, M J <mjbaars1977.gdb@gmail.com> writes:

Michael> Oops... did I remove one of your entries in the ChangeLog? :)

As others have noted, ChangeLog is "prepend only".
We generally don't edit old entries.

Michael> +struct
Michael> +{
Michael> + char *tag;
Michael> + char *description;
Michael> +}

Wrong indentation here, should be 2 spaces.
Fields should have descriptive comments.
I think the struct should have a tag and be terminated here.
Also the fields should be "const".

Michael> +static const npx_exception_flags[6] =
Michael> +
Michael> +{
Michael> + {"IE", "invalid operation"},

Wrong indentation. This is a problem in the whole patch.

Michael> +// print the numeric coprocessor extension (npx) status word

No `//' comments.
Comments should be full sentences, see GNU standards.

Michael> +void print_npx_status_word(uint16_t npx_status_word, struct ui_file *file)

Newline after "void".
Space before "(" -- a problem in a few spots.
Again, GNU standards.

Tom