From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFA] ARI fix: avoid assignment in if clause in xcoffread.c
Date: Tue, 19 Apr 2011 14:02:00 -0000 [thread overview]
Message-ID: <201104191501.53552.pedro@codesourcery.com> (raw)
In-Reply-To: <000901cbfe97$9ed7f120$dc87d360$@muller@ics-cnrs.unistra.fr>
On Tuesday 19 April 2011 14:42:25, Pierre Muller wrote:
> If I understand the code correctly, this patch
> should have no effect, the only thing that could have is
> an unnecessary call to strchr.
> The other alternative would be to
> do a
> + if (*name == ':')
> + retrun NULL;
> + pp = (char *) strchr (name, ':');
> + if (pp == NULL)
> would that be better?
Yes, okay with that change.
--
Pedro Alves
next prev parent reply other threads:[~2011-04-19 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 13:42 Pierre Muller
2011-04-19 14:02 ` Pedro Alves [this message]
2011-04-19 14:13 ` Pierre Muller
[not found] ` <36908.1941120841$1303222432@news.gmane.org>
2011-04-19 14:33 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104191501.53552.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox