From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80430-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21831 invoked by alias); 19 Apr 2011 12:52:05 -0000
Received: (qmail 21786 invoked by uid 22791); 19 Apr 2011 12:51:45 -0000
X-Spam-Check-By: sourceware.org
Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234)    by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Tue, 19 Apr 2011 12:51:18 +0000
Received: by calimero.vinschen.de (Postfix, from userid 500)	id 4BB772C0135; Tue, 19 Apr 2011 14:51:15 +0200 (CEST)
Date: Tue, 19 Apr 2011 12:52:00 -0000
From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c
Message-ID: <20110419125115.GA21525@calimero.vinschen.de>
Reply-To: gdb-patches@sourceware.org
Mail-Followup-To: gdb-patches@sourceware.org
References: <006e01cbfe7e$5a8dadc0$0fa90940$@muller@ics-cnrs.unistra.fr> <201104191208.01363.pedro@codesourcery.com> <007e01cbfe8f$0f9e4480$2edacd80$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <007e01cbfe8f$0f9e4480$2edacd80$@muller@ics-cnrs.unistra.fr>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00312.txt.bz2

On Apr 19 14:41, Pierre Muller wrote:
> Thank you for the suggestion, this makes the things
> cleaner.
> [...]
>   So here is the new proposal:
> 
> Corinna, you are listed as maintainer of
> xstormy16-tdep, could you tell if this is OK?

Except for a missing space, yes.

> Pierre Muller
> 
> 
> 2011-04-19  Pierre Muller  <muller@ics.u-strasbg.fr>
> 	    Pedro Alves  <pedro@codesourcery.com>
> 
> 	* xstormy16-tdep.c (xstormy16_push_dummy_call): Add local
> 	variables to simplify code and avoid == operator at end of
> 	line as this is against GNU coding standards.
> 
> Index: xstormy16-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/xstormy16-tdep.c,v
> retrieving revision 1.114
> diff -u -p -r1.114 xstormy16-tdep.c
> --- xstormy16-tdep.c	18 Mar 2011 18:52:32 -0000	1.114
> +++ xstormy16-tdep.c	19 Apr 2011 12:34:34 -0000
> @@ -263,12 +263,13 @@ xstormy16_push_dummy_call (struct gdbarc
>        /* Put argument into registers wordwise.  */
>        val = value_contents (args[i]);
>        for (j = 0; j < typelen; j += xstormy16_reg_size)
> -	regcache_cooked_write_unsigned (regcache, argreg++,
> -			extract_unsigned_integer (val + j,
> -						  typelen - j ==
> -						  1 ? 1 :
> -						  xstormy16_reg_size,
> -						  byte_order));
> +	{
> +	  ULONGEST regval;
> +	  int size = (typelen -j == 1) ? 1 : xstormy16_reg_size;
                              ^^^
                              - j

> +
> +	  regval = extract_unsigned_integer (val + j, size, byte_order);
> +	  regcache_cooked_write_unsigned (regcache, argreg++, regval);
> +	}
>      }
>  
>    /* Align SP */

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat