From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-80425-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25196 invoked by alias); 19 Apr 2011 11:08:17 -0000
Received: (qmail 25188 invoked by uid 22791); 19 Apr 2011 11:08:16 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 11:08:03 +0000
Received: (qmail 1664 invoked from network); 19 Apr 2011 11:08:02 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 19 Apr 2011 11:08:02 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA] ARI fix: Remove OP at end of line in xstormy16-tdep.c
Date: Tue, 19 Apr 2011 11:08:00 -0000
User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; )
Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
References: <006e01cbfe7e$5a8dadc0$0fa90940$@muller@ics-cnrs.unistra.fr>
In-Reply-To: <006e01cbfe7e$5a8dadc0$0fa90940$@muller@ics-cnrs.unistra.fr>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201104191208.01363.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-04/txt/msg00307.txt.bz2

On Tuesday 19 April 2011 11:41:34, Pierre Muller wrote:
> --- xstormy16-tdep.c    18 Mar 2011 18:52:32 -0000      1.114
> +++ xstormy16-tdep.c    19 Apr 2011 10:35:47 -0000
> @@ -264,11 +264,9 @@ xstormy16_push_dummy_call (struct gdbarc
>        val = value_contents (args[i]);
>        for (j = 0; j < typelen; j += xstormy16_reg_size)
>         regcache_cooked_write_unsigned (regcache, argreg++,
> -                       extract_unsigned_integer (val + j,
> -                                                 typelen - j ==
> -                                                 1 ? 1 :
> -                                                 xstormy16_reg_size,
> -                                                 byte_order));
> +         extract_unsigned_integer (val + j,
> +                                   typelen - j == 1 ? 1 :
> xstormy16_reg_size,
> +                                   byte_order));

A sign that temporary variables would help, IMO:

       for (j = 0; j < typelen; j += xstormy16_reg_size)
		  {
	       ULONGEST regval;
          int size;

			size = typelen - j == 1 ? 1 : xstormy16_reg_size;
          val = extract_unsigned_integer (val + j, size, byte_order);
          regcache_cooked_write_unsigned (regcache, argreg++, regval);
         );

-- 
Pedro Alves