From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21536 invoked by alias); 19 Apr 2011 11:02:54 -0000 Received: (qmail 21527 invoked by uid 22791); 19 Apr 2011 11:02:53 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Apr 2011 11:02:39 +0000 Received: (qmail 462 invoked from network); 19 Apr 2011 11:02:38 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 19 Apr 2011 11:02:38 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] Lowercase static function names that use capital letters. Date: Tue, 19 Apr 2011 11:02:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: "Pierre Muller" References: <005801cbfe7a$414b24e0$c3e16ea0$@muller@ics-cnrs.unistra.fr> In-Reply-To: <005801cbfe7a$414b24e0$c3e16ea0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104191202.36603.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00306.txt.bz2 On Tuesday 19 April 2011 11:12:13, Pierre Muller wrote: > Is this patch OK or are there any valid reasons to use > uppercase function like LM_NEXT? I think only history, and that nobody ever bothered to lowercase them. These started out as macros, and when the macros were turned into real functions (when the sunos and svr4 support was split out of solib.c, I think), the naming/casing was preserved. > 2011-04-19 Pierre Muller > > ARI fixes: Use only lowercase function name for static functions. > * nto-tdep.c (LM_ADDR): Rename to... > (lm_addr): New function name. > (nto_relocate_section_addresses): Adapt to change above. > * solib-sunos.c (LM_ADDR): Rename to... > (lm_addr): New function name. > (LM_NEXT): Rename to... > (lm_next): New function name. > (sunos_current_sos, sunos_relocate_section_addresses): Adapt to > function name changes above. > * solib-svr4.c (LM_ADDR_FROM_LINK_MAP): Rename to... > (lm_addr_from_link_map): New function name. > (HAS_LM_DYNAMIC_FROM_LINK_MAP): Rename to... > (has_lm_dynamic_from_link_map): New function name. > (LM_DYNAMIC_FROM_LINK_MAP): Rename to... > (lm_dynamic_from_link_map): New function name. > (LM_ADDR_CHECK): Rename to... > (lm_addr_check): New function name. > (LM_NEXT): Rename to... > (lm_next): New function name. > (LM_PREV): Rename to... > (lm_prev): New function name. > (LM_NAME): Rename to... > (lm_name): New function name. > (IGNORE_FIRST_LINK_MAP_ENTRY): Rename to... > (ignore_first_link_map_entry): New function name. > (svr4_keep_data_in_core): Adapt to function name changes above. > (svr4_current_sos): Likewise. > (enable_break): Likewise. > (svr4_relocate_section_addresses): Likewise. Okay. -- Pedro Alves