From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16996 invoked by alias); 16 Apr 2011 16:33:25 -0000 Received: (qmail 16972 invoked by uid 22791); 16 Apr 2011 16:33:23 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 16 Apr 2011 16:33:08 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p3GGUTQD026749; Sat, 16 Apr 2011 18:30:30 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p3GGUSsS026236; Sat, 16 Apr 2011 18:30:28 +0200 (CEST) Date: Sat, 16 Apr 2011 16:33:00 -0000 Message-Id: <201104161630.p3GGUSsS026236@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: mjbaars1977.gdb@gmail.com CC: dan@codesourcery.com, gdb-patches@sourceware.org, gdb@sourceware.org In-reply-to: <4DA9C1FC.8040600@gmail.com> (mjbaars1977.gdb@gmail.com) Subject: Re: print_npx_status_word References: <4DA7ED79.3000400@gmail.com> <4DA87235.7060003@gmail.com> <4DA87479.50203@gmail.com> <4DA93270.6030708@gmail.com> <201104160824.p3G8ONWV006175@glazunov.sibelius.xs4all.nl> <4DA99DA1.2090708@gmail.com> <20110416142809.GA28255@caradoc.them.org> <4DA9C1FC.8040600@gmail.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00245.txt.bz2 > Date: Sat, 16 Apr 2011 18:21:16 +0200 > From: "Baars, M.J." > > On 04/16/2011 04:29 PM, Daniel Jacobowitz wrote: > > On Sat, Apr 16, 2011 at 03:46:09PM +0200, Baars, M.J. wrote: > >> On 04/16/2011 10:24 AM, Mark Kettenis wrote: > >>>> Date: Sat, 16 Apr 2011 08:08:48 +0200 > >>>> From: "Baars, M.J." > >>>> > >>>> Hi Tom, > >>>> > >>>> I believe this is the format you requested? > >>> No! This is a .tar.gz. Proper diffs don't come as a .tar.gz. > >> Oops... did I remove one of your entries in the ChangeLog? :) > > If you want a patch to be committed, eventually you're going to have > > to say why. What's the goal of the patch? > When you look at the code in question more closely, you will see that it > will present the content of the status word in more detail than the > original function, Which isn't necessarily a good thing. > > Also, why on earth are you messing about with old changelog entries? > > > The old function can thus be seen as obsolete, and should be removed > from the old log entries. Seems you totally fail to understand what ChangeLogs are for.