From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27192 invoked by alias); 13 Apr 2011 15:55:46 -0000 Received: (qmail 27180 invoked by uid 22791); 13 Apr 2011 15:55:44 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 15:55:36 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3DFtZwI028206 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Apr 2011 11:55:36 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3DFtXfI027592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Apr 2011 11:55:35 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p3DFtX5U010291; Wed, 13 Apr 2011 17:55:33 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p3DFtWth010290; Wed, 13 Apr 2011 17:55:32 +0200 Date: Wed, 13 Apr 2011 15:55:00 -0000 From: Jan Kratochvil To: Marek Polacek Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb.base/commands.exp: fix racy test (PR testsuite/12649) Message-ID: <20110413155532.GA9302@host1.jankratochvil.net> References: <4DA55797.5090800@redhat.com> <20110413092029.GA19366@host1.jankratochvil.net> <4DA5C2F9.908@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DA5C2F9.908@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00187.txt.bz2 Hi Marek, On Wed, 13 Apr 2011 17:36:25 +0200, Marek Polacek wrote: > 2011-04-13 Marek Polacek > > * gdb.base/commands.exp (redefine_backtrace_test): Fix race. > New testcase `expect response to define backtrace'. Also remove > redundant `default' block. checked in for you. If you expect more contributions you should consider write-after-approval sourceware account: http://sourceware.org/cgi-bin/pdw/ps_form.cgi > Signed-off-by: Marek Polacek FYI this is redundant for GNU projects, FSF copyright assignment covered by Red Hat in your case applies instead. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2011-04/msg00076.html --- src/gdb/testsuite/ChangeLog 2011/04/11 17:40:41 1.2661 +++ src/gdb/testsuite/ChangeLog 2011/04/13 15:54:04 1.2662 @@ -1,3 +1,9 @@ +2011-04-13 Marek Polacek + + * gdb.base/commands.exp (redefine_backtrace_test): Fix race. + New testcase `expect response to define backtrace'. Also remove + redundant `default' block. + 2011-04-11 Jan Kratochvil * gdb.python/py-prettyprint.c (struct hint_error): New. --- src/gdb/testsuite/gdb.base/commands.exp 2011/01/01 15:33:41 1.42 +++ src/gdb/testsuite/gdb.base/commands.exp 2011/04/13 15:54:05 1.43 @@ -704,18 +704,17 @@ global gdb_prompt gdb_test_multiple "define backtrace" "define backtrace" { - -re "Really redefine built-in.*$" { - send_gdb "y\n" - exp_continue + -re "Really redefine built-in command \"backtrace\"\\? \\(y or n\\) $" { + pass "define backtrace" } + } - -re "End with" { - pass "define backtrace in redefine_backtrace_test" - } - default { - fail "(timeout or eof) define backtrace in redefine_backtrace_test" + gdb_test_multiple "y" "expect response to define backtrace" { + -re "End with a line saying just \"end\"\\.\r\n>$" { + pass "expect response to define backtrace" } } + gdb_test "echo hibob\\n\nend" \ "" \ "enter commands in redefine_backtrace_test"