From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12648 invoked by alias); 12 Apr 2011 11:18:14 -0000 Received: (qmail 12635 invoked by uid 22791); 12 Apr 2011 11:18:13 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Apr 2011 11:18:09 +0000 Received: (qmail 3589 invoked from network); 12 Apr 2011 11:18:09 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 12 Apr 2011 11:18:09 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] Introduce `pre_expanded sals' Date: Tue, 12 Apr 2011 11:18:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: Tom Tromey , Sergio Durigan Junior References: In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201104121218.08910.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00162.txt.bz2 On Wednesday 06 April 2011 21:13:36, Tom Tromey wrote: > >>>>> "Sergio" == Sergio Durigan Junior writes: > > Sergio> This patch introduces the `pre_expanded sals'. Tom, please, if > Sergio> you have additional comments to make regarding this > Sergio> modification, feel free to reply to this message. > > This is just a way for decode_line_1 to tell the breakpoint code that > the returned sals has multiple locations but should still create just a > single breakpoint. We needed this because a given SystemTap probe name > may have multiple locations. Hmm, doesn't sound right. Conceptually, breakpoint locations are multiple expansions of the same source location. Different source locations are different breakpoints. E.g, bp_location doesn't have line number or source file fields. From the user's perpective, there's only a single "point" in the source code for all the multiple locations for a single breakpoint. -- Pedro Alves