From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9336 invoked by alias); 12 Apr 2011 11:06:14 -0000 Received: (qmail 9328 invoked by uid 22791); 12 Apr 2011 11:06:13 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Apr 2011 11:06:09 +0000 Received: (qmail 520 invoked from network); 12 Apr 2011 11:06:07 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 12 Apr 2011 11:06:07 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch][branch] Fix saving -location watchpoints. Date: Tue, 12 Apr 2011 11:06:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-28-generic; KDE/4.6.2; x86_64; ; ) Cc: Thiago Jung Bauermann References: <1302295653.2074.15.camel@hactar> In-Reply-To: <1302295653.2074.15.camel@hactar> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201104121206.07705.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00161.txt.bz2 On Friday 08 April 2011 21:47:33, Thiago Jung Bauermann wrote: > Hi, > > watch_command_1 sets b->exp_string to "-location: foobar". When saving > breakpoints to a file, save_breakpoints will use b->exp_string to > construct a command line for recreating the watchpoint, and comes up > with the invalid command "watch -location: foobar". This patch simply > removes the colon from exp_string. > > No regressions on i386-linux. Ok for HEAD and the branch? This is okay with me. -- Pedro Alves