From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13326 invoked by alias); 12 Apr 2011 11:53:29 -0000 Received: (qmail 13315 invoked by uid 22791); 12 Apr 2011 11:53:28 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Apr 2011 11:53:19 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3CBrDOh029099 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Apr 2011 07:53:13 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3CBrA7J009877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Apr 2011 07:53:12 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p3CBrA75002471; Tue, 12 Apr 2011 13:53:10 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p3CBr9nl002468; Tue, 12 Apr 2011 13:53:09 +0200 Date: Tue, 12 Apr 2011 11:53:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Tom Tromey , Sergio Durigan Junior Subject: Re: [PATCH 2/6] Introduce `pre_expanded sals' Message-ID: <20110412115308.GA384@host1.jankratochvil.net> References: <201104121218.08910.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201104121218.08910.pedro@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00164.txt.bz2 On Tue, 12 Apr 2011 13:18:08 +0200, Pedro Alves wrote: > Hmm, doesn't sound right. Conceptually, breakpoint locations are > multiple expansions of the same source location. Different source locations > are different breakpoints. E.g, bp_location doesn't have line > number or source file fields. From the user's perpective, there's > only a single "point" in the source code for all the multiple locations > for a single breakpoint. What about generalizing this so that breakpoint locations is a set of PCs matching the breakpoint expression? Currently I do not understand how to fix: KFAIL: gdb.cp/re-set-overloaded.exp: start (GDB internal error) (PRMS: breakpoints/11657) as currently breakpoint_re_set would need to create/delete user-visible breakpoint numbers. With the "new" (for some years) syntax `enable X.Y' ane `disable X.Y' one can control which breakpoints are active easily. (gdb) break C::C Breakpoint 1 at 0x7d1: file ./gdb.cp/re-set-overloaded.cc, line 22. Breakpoint 2 at 0x7ba: file ./gdb.cp/re-set-overloaded.cc, line 21. (2 locations) warning: Multiple breakpoints were set. Use the "delete" command to delete unwanted breakpoints. (gdb) disable 2.2 (gdb) info breakpoints Num Type Disp Enb Address What 1 breakpoint keep y 0x00000000000007d1 in C::C(int) at ./gdb.cp/re-set-overloaded.cc:22 2 breakpoint keep y 2.1 y 0x00000000000007ba in C::C() at ./gdb.cp/re-set-overloaded.cc:21 2.2 n 0x00000000000007c4 in C::C() at ./gdb.cp/re-set-overloaded.cc:21 So that `set multiple-symbols ask' could be removed (probably completely incl. the `cancel' option). I find the current two kinds of multiple breakpoints confusing to users (at least to myself). Thanks, Jan