From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 508 invoked by alias); 7 Apr 2011 21:43:11 -0000 Received: (qmail 498 invoked by uid 22791); 7 Apr 2011 21:43:11 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from g1t0027.austin.hp.com (HELO g1t0027.austin.hp.com) (15.216.28.34) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Apr 2011 21:43:04 +0000 Received: from g1t0038.austin.hp.com (g1t0038.austin.hp.com [16.236.32.44]) by g1t0027.austin.hp.com (Postfix) with ESMTP id E55D738B6C for ; Thu, 7 Apr 2011 21:43:03 +0000 (UTC) Received: from lucas.cup.hp.com (lucas.cup.hp.com [15.244.97.116]) by g1t0038.austin.hp.com (Postfix) with ESMTP id A46353073F for ; Thu, 7 Apr 2011 21:43:03 +0000 (UTC) Received: (from sje@localhost) by lucas.cup.hp.com (8.11.1 (PHNE_35485)/8.11.1) id p37Lh2823337 for gdb-patches@sourceware.org; Thu, 7 Apr 2011 14:43:02 -0700 (PDT) Date: Thu, 07 Apr 2011 21:43:00 -0000 From: Steve Ellcey Message-Id: <201104072143.p37Lh2823337@lucas.cup.hp.com> To: gdb-patches@sourceware.org Subject: Patch for IA64 Linux build, PR build/12646 Reply-to: sje@cup.hp.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00114.txt.bz2 I submitted a defect, PR build/12646, about gdb not building on IA64 Linux. I have come up with this patch to fix it but I am not sure if it is the right patch, I.e. is this the right stop_reason function to put into the libunwind_frame_unwind structure. Apparently this file is only used when using the system unwind library and IA64 may be the only platform that does that. It does fix the build and when I run the testsuite I get this summary on the gdb.base runs: === gdb Summary === # of expected passes 4995 # of unexpected failures 171 # of unexpected successes 1 # of expected failures 29 # of known failures 20 # of untested testcases 3 # of unsupported tests 4 I don't have a baseline for what failures to expect on IA64 Linux, I don't run the gdb testsuite very often and my recollection is that it is not a very clean run even before the build broke. Can someone look this patch over and approve it if it looks OK? I'd like to get the build problem fixed for 7.3 as well as on the main line. Steve Ellcey sje@cup.hp.com 2011-04-07 Steve Ellcey * libunwind-frame.c (libunwind_frame_unwind): Add default_frame_unwind_stop_reason value to initalization. Index: libunwind-frame.c =================================================================== RCS file: /cvs/src/src/gdb/libunwind-frame.c,v retrieving revision 1.31 diff -u -c -r1.31 libunwind-frame.c *** libunwind-frame.c 13 Jan 2011 16:23:22 -0000 1.31 --- libunwind-frame.c 7 Apr 2011 21:26:39 -0000 *************** *** 237,242 **** --- 237,243 ---- static const struct frame_unwind libunwind_frame_unwind = { NORMAL_FRAME, + default_frame_unwind_stop_reason, libunwind_frame_this_id, libunwind_frame_prev_register, NULL,