From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30534 invoked by alias); 6 Apr 2011 20:55:47 -0000 Received: (qmail 30526 invoked by uid 22791); 6 Apr 2011 20:55:46 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.uk.ibm.com (HELO mtagate4.uk.ibm.com) (194.196.100.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Apr 2011 20:55:42 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p36KtesV026179 for ; Wed, 6 Apr 2011 20:55:40 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p36KuNRX1896542 for ; Wed, 6 Apr 2011 21:56:23 +0100 Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p36Ktecd009305 for ; Wed, 6 Apr 2011 14:55:40 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p36KtdDi009302; Wed, 6 Apr 2011 14:55:39 -0600 Message-Id: <201104062055.p36KtdDi009302@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 06 Apr 2011 22:55:39 +0200 Subject: Re: [try 2nd 3/8] Refactor copy_svc_os To: yao@codesourcery.com (Yao Qi) Date: Wed, 06 Apr 2011 20:55:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <4D8B4D84.4020002@codesourcery.com> from "Yao Qi" at Mar 24, 2011 09:56:20 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00099.txt.bz2 Yao Qi wrote: > 2011-03-24 Yao Qi > > * gdb/arm-linux-tdep.c (arm_linux_copy_svc): Remove parameters INSN > and TO. > * gdb/arm-tdep.c (cleanup_svc): Handle variable instruction size. > (arm_copy_svc): Remove parameters INSN and TO. > (decode_svc_copro): Update caller. > * gdb/arm-tdep.h (struct displaced_step_closure): Remove parameters > from function pointer `copy_svc_os'. This looks OK to me. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com