From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32443 invoked by alias); 5 Apr 2011 08:47:37 -0000 Received: (qmail 32430 invoked by uid 22791); 5 Apr 2011 08:47:36 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Apr 2011 08:47:28 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p358lSPj019096 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 5 Apr 2011 04:47:28 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p358lQsY012420 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 5 Apr 2011 04:47:28 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p358lQUP029306; Tue, 5 Apr 2011 10:47:26 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p358lPOX029305; Tue, 5 Apr 2011 10:47:25 +0200 Date: Tue, 05 Apr 2011 08:47:00 -0000 From: Jan Kratochvil To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: [patch] Regression: Re: FYI: clean up symtab producer and debugformat lifetimes Message-ID: <20110405084724.GA28800@host1.jankratochvil.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00071.txt.bz2 Hi Tom, On Mon, 04 Apr 2011 16:28:53 +0200, Tom Tromey wrote: > I'm checking this in on the trunk. symtab is not subfile. This and several other regressions on all the tested platforms: -PASS: gdb.base/included.exp: list integer +XPASS: gdb.base/included.exp: list integer -PASS: gdb.base/included.exp: info variables integer +XPASS: gdb.base/included.exp: info variables integer Due to: (gdb) info source Compiled with unknown debugging format. 4b11999f6f77676a5913d772e3b29e04fa057047 is the first bad commit commit 4b11999f6f77676a5913d772e3b29e04fa057047 Author: Tom Tromey Date: Mon Apr 4 14:29:26 2011 +0000 * xcoffread.c (read_xcoff_symtab): Make `debugfmt' const. * symtab.h (struct symtab) : Now const. * symmisc.c (free_symtab): Don't free debugformat. * buildsym.h (struct subfile) : Now const. (record_debugformat, record_producer): Document. * buildsym.c (end_symtab): Don't save debugformat and producer names on obstack. (end_symtab): Don't free debugformat and producer fields. (record_debugformat): Don't call xstrdup. (record_producer): Likewise. :040000 040000 264d42cf955972c5478af0b3515c24683d8d6521 cf07823a615c5afdf0a0f14a60ea77fe5e7baddd M gdb bisect run success No regressions on {x86_64,x86_64-m32,i686}-fedora{13,14,15,-rawhide}-linux-gnu together with the objfile-data (to be posted along) fix against yesterday. I will check it in today. Thanks, Jan gdb/ 2011-04-05 Jan Kratochvil Fix regression of displaying the debug format. * buildsym.c (end_symtab): Set symtab's debugformat and producer from subfile. --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -1109,6 +1109,12 @@ end_symtab (CORE_ADDR end_addr, struct objfile *objfile, int section) the symbols. */ symtab->language = subfile->language; + /* Save the debug format string (if any) in the symtab. */ + symtab->debugformat = subfile->debugformat; + + /* Similarly for the producer. */ + symtab->producer = subfile->producer; + /* All symtabs for the main file and the subfiles share a blockvector, so we need to clear primary for everything but the main file. */