Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, Keith Seitz <keiths@redhat.com>
Subject: FAIL: gdb.cp/cpexprs.exp: list base::overload(void)
Date: Fri, 01 Apr 2011 15:09:00 -0000	[thread overview]
Message-ID: <201104011609.07889.pedro@codesourcery.com> (raw)

I've been seeing these failures for a long while:

FAIL: gdb.cp/cpexprs.exp: list base::overload(void)
FAIL: gdb.cp/cpexprs.exp: setting breakpoint at base::overload(void)
FAIL: gdb.cp/cpexprs.exp: continue to base::overload(void)

gdb.log shows:

 list base::overload(void)
 the class `base' does not have any method instance named overload(void)
 (gdb) FAIL: gdb.cp/cpexprs.exp: list base::overload(void)

and indeed, base::overload(void) is const:

  // Some overloaded methods
  int overload (void) const { return 0; } // base::overload(void) const
  int overload (int i) const { return 1; } // base::overload(int) const
  int overload (short s) const { return 2; } // base::overload(short) const
  int overload (long l) const { return 3; } // base::overload(long) const
  int overload (char* a) const { return 4; } // base::overload(char*) const
  int overload (base& b) const { return 5; } // base::overload(base&) const

cpexprs.exp test all the other overloads with an explicit "const", but
the (void) one is tested for both const and non-nonst variants:

> # Overloaded methods (all are const -- we try to use the void
> # method with and without specifying "const")

Why is the non-const variant tried and expected to pass?

I tested as far back as 6.8 and it didn't work then either.  Is this
trying to be a reminder that GDB could be more forgiving and accept
the non-const overload, perhaps?  That'd sound more like as a
it-would-be-nice-if / feature-request than a bug, and shouldn't
be a FAIL.

Can we just drop it, like below?

-- 
Pedro Alves

Index: src/gdb/testsuite/gdb.cp/cpexprs.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.cp/cpexprs.exp	2011-04-01 15:52:15.339770000 +0100
+++ src/gdb/testsuite/gdb.cp/cpexprs.exp	2011-04-01 15:53:18.469770000 +0100
@@ -196,12 +196,7 @@ add {base::~base} \
     - \
     -
 
-# Overloaded methods (all are const -- we try to use the void
-# method with and without specifying "const")
-add {base::overload(void)} \
-    {int (const base * const)} \
-    - \
-    {base::overload(void) const}
+# Overloaded methods (all are const)
 add {base::overload(void) const} \
     {int (const base * const)} \
     - \


             reply	other threads:[~2011-04-01 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-01 15:09 Pedro Alves [this message]
2011-04-01 15:53 ` Keith Seitz
2011-04-01 16:09   ` Pedro Alves
2011-04-01 16:28     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104011609.07889.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=keiths@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox