Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>,
	"'Eli Zaretskii'" <eliz@gnu.org>
Subject: Re: [RFC] Missing sleep function for mingw hosts
Date: Tue, 29 Mar 2011 15:40:00 -0000	[thread overview]
Message-ID: <201103291523.46954.pedro@codesourcery.com> (raw)
In-Reply-To: <003001cbee11$49bb0880$dd311980$@muller@ics-cnrs.unistra.fr>

On Tuesday 29 March 2011 14:00:32, Pierre Muller wrote:
>   Hi Eli,
> > > I found that there is a substitute for sleep in gnulib:
> > >
> >
> http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/sleep.c;hb=d60
> > > f3b0c6b0f93a601acd1cfd3923f94ca05abb0
> > >
> > >   What is the rule to add new parts into gnulib subdirectory?
> > > Would inclusion of gnulib sleep.c source code
> > > be possible to fix the above problem?
> > 
> > I'd rather we had a replacement in win32-nat.c, instead of importing
> > gobs of gnulib stuff needed to provide such a trivial replacement.
> > gnulib is GPL, so we can simply copy the code into our sources.

gnulib has a mechanism (which we are already using) where
we just import the modules we need.  We don't import the whole thing.  We
currently import the memmem module.  We would just need to import the
"sleep" module in addition (and whatever dependencies that
may have --- which are handled automatically by gnulib's import script).

I have no clue why that `sleep' is necessary, but in any case, can't
we use already existing `gdb_usleep' function instead and be done
with it?

-- 
Pedro Alves


  reply	other threads:[~2011-03-29 14:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29  8:11 Pierre Muller
2011-03-29 13:10 ` Eli Zaretskii
2011-03-29 14:23   ` Pierre Muller
2011-03-29 15:40     ` Pedro Alves [this message]
2011-03-29 15:41       ` Kai Tietz
2011-03-29 15:43       ` [RFA] use gdb_usleep instead of sleep in remote-mips.c (was Missing sleep function for mingw hosts) Pierre Muller
2011-03-29 15:53         ` Joel Brobecker
2011-03-29 16:54           ` Pierre Muller
2011-03-29 22:05       ` [RFC] Missing sleep function for mingw hosts Eli Zaretskii
2011-03-30  0:06         ` Matt Rice
2011-03-30  4:12           ` Eli Zaretskii
2011-03-30  6:25             ` Matt Rice
2011-03-30  9:25               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103291523.46954.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox