From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23782 invoked by alias); 28 Mar 2011 21:27:00 -0000 Received: (qmail 23773 invoked by uid 22791); 28 Mar 2011 21:26:59 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Mar 2011 21:26:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id AD05A2BAF97; Mon, 28 Mar 2011 17:26:55 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2KO4uWCRob3f; Mon, 28 Mar 2011 17:26:55 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 820C02BAFF9; Mon, 28 Mar 2011 17:26:55 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 26A57145869; Mon, 28 Mar 2011 14:26:51 -0700 (PDT) Date: Tue, 29 Mar 2011 01:55:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [RFA] Refactor breakpoint_re_set_one Message-ID: <20110328212651.GG3670@adacore.com> References: <1301322874.2433.0.camel@hactar> <20110328184647.GD3670@adacore.com> <1301347008.2433.11.camel@hactar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1301347008.2433.11.camel@hactar> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01152.txt.bz2 > Fixed. BTW: I know the error was there before... > 2011-03-28 Thiago Jung Bauermann > > * breakpoint.c (breakpoint_re_set_one): Factor out breakpoint-resetting > code from here ... > (re_set_breakpoint): ... to here ... > (addr_string_to_sals): ... and here. This looks very good to me! Thanks :) -- Joel