Re: [patch] ada testsuite: False FAILs with gcc debug info

[Joel Brobecker <brobecker@adacore.com>]

> I do not understand this much.  I have the single system only
> compiler, which also provides debug info for all its parts.  While I
> can have some special GCC builds still with the default system
> compiler the GDB testsuite should work.

That's the thing, as far as I know, you need to change something
in order to be able to build the runtime with debugging information.
It's been a long time since I worked on that part of the compiler,
but, by default, we do not produce a runtime with debugging info.
For those of us that need to debug the runtime, we usually using
"gnatmake -f -a".

> (gdb) ptype ada.strings.maps.character_set
> type = array (character) of boolean <packed: 1-bit elements>
> (gdb) ptype "a"
> type = array (1 .. 1) of character
> 
> and ada_type_match for TYPE_CODE_ARRAY returns 1 without checking
> whether the array's target type matches.  And both these types are
> arrays.  Why Character_Set should not match String with this
> ada_type_match implementation?
>
> So far it seems to me ada_type_match has a bug, does not it?

Yeah, that looks like a hole in the implementation indeed.
I think I wasn't seeing the problem with `gnatmake -f -a'
because ada.strings.maps simply wasn't used at all.

You can assign the PR to me. It might be delicate to solve,
because the matching rules are complex (at least to me).

-- 
Joel