From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30522 invoked by alias); 28 Mar 2011 20:08:58 -0000 Received: (qmail 30508 invoked by uid 22791); 28 Mar 2011 20:08:56 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 Mar 2011 20:08:51 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2SK8SLp002696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Mar 2011 16:08:28 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2SK8Q0I029600 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 28 Mar 2011 16:08:28 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p2SK8Qrm026239; Mon, 28 Mar 2011 22:08:26 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p2SK8PEX026238; Mon, 28 Mar 2011 22:08:25 +0200 Date: Mon, 28 Mar 2011 20:21:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] ada testsuite: False FAILs with gcc debug info Message-ID: <20110328200825.GA22355@host1.jankratochvil.net> References: <20110327081139.GA30398@host1.jankratochvil.net> <20110328165022.GB3670@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110328165022.GB3670@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01139.txt.bz2 On Mon, 28 Mar 2011 18:50:22 +0200, Joel Brobecker wrote: > Just a thought: Perhaps it might be easier to flip runtimes if you > provide the runtime with debug info as a second runtime. There is > a way to do this, and then the user controls which one he wants using > --RTS= (only when the default one is not the one he wants). I do not understand this much. I have the single system only compiler, which also provides debug info for all its parts. While I can have some special GCC builds still with the default system compiler the GDB testsuite should work. > This is incorrect, but I cannot reproduce (we should be able to get > the same behavior by recompiling the program with "-f -a", which tells > gnatmake to recompile everything, including runtime files). `gnatmake -f -a -g foo' works but it gives the same results for me. > And type Character_Set does not match type String: It does match: (gdb) set language c (gdb) ptype ada__strings__maps__Oeq type = boolean (ada__strings__maps__character_set___XP1 &, ada__strings__maps__character_set___XP1 &) (gdb) set language auto (gdb) ptype ada.strings.maps.character_set type = array (character) of boolean (gdb) ptype "a" type = array (1 .. 1) of character and ada_type_match for TYPE_CODE_ARRAY returns 1 without checking whether the array's target type matches. And both these types are arrays. Why Character_Set should not match String with this ada_type_match implementation? > I think the debugging info must be incorrect. So far it seems to me ada_type_match has a bug, does not it? > > gdb/testsuite/ > > 2011-03-27 Jan Kratochvil > > > > * gdb.ada/arrayparam.exp (print first after function call): Use > > explicit package name. Add a comment > > (print lasta after function call): Rename ... > > (print last after function call): ... it and use explicit package > > name. > > (print length after function call): Use explicit package name. > > * gdb.ada/str_ref_cmp.exp (operator = works for strings): New test. > > * gdb.ada/sym_print_name.exp: Change `i' to `integervar'. > > (multiple matches for symbol i): Rename ... > > (multiple matches for symbol integervar): ... it. > > * gdb.ada/sym_print_name/foo.adb (Foo): Change `I' to `IntegerVar'. > > * gdb.ada/sym_print_name/pck.ads (Pck): Likewise. > > This is OK. Therefore checked in so that it no longer occasionally gives false regressions. http://sourceware.org/ml/gdb-cvs/2011-03/msg00308.html Thanks, Jan