From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26442 invoked by alias); 24 Mar 2011 15:14:23 -0000 Received: (qmail 26224 invoked by uid 22791); 24 Mar 2011 15:14:22 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Mar 2011 15:14:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8EDB52BB2A0; Thu, 24 Mar 2011 11:14:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 9hIdmgPVX0jW; Thu, 24 Mar 2011 11:14:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 34EFE2BB29F; Thu, 24 Mar 2011 11:14:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9D9521459BF; Thu, 24 Mar 2011 08:14:03 -0700 (PDT) Date: Thu, 24 Mar 2011 15:50:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH v2] sim: cfi: new flash device simulation Message-ID: <20110324151403.GM2520@adacore.com> References: <1293750414-14626-1-git-send-email-vapier@gentoo.org> <1300945105-25242-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1300945105-25242-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01074.txt.bz2 > 2010-12-30 Mike Frysinger > > * aclocal.m4 (SIM_AC_OPTION_HARDWARE): Add cfi to default list. > * Make-common.in (dv-cfi.o): New rule. > * dv-cfi.c, dv-cfi.h: New files. Almost OK. There are just a few minor comments: - opening curly brace in struct union declarations should be on the next line - We're not fond of commented out code. You could replace it by a comment if useful. - I realize that this is a large-ish job, but it would be nice to have all types and routines documented. Generally, it's even preferable to document the fields in the struct/union types, but a small description of the type will be a good start for now. - I think that this deserves a NEWS entry - And I think that we should add some documentation in the GDB Manual. The simulator section is almost non-existent in the current manual, but if we could start defining a general structure, even if they are empty, and document this new feature in that structure, at least we won't make things worse. -- Joel