From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25540 invoked by alias); 22 Mar 2011 17:25:12 -0000 Received: (qmail 25514 invoked by uid 22791); 22 Mar 2011 17:25:11 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Mar 2011 17:25:06 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A1C592BB10B; Tue, 22 Mar 2011 13:25:04 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 13ChFv4Rb82R; Tue, 22 Mar 2011 13:25:04 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 72F322BB0C2; Tue, 22 Mar 2011 13:25:04 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id DC7E31459AD; Tue, 22 Mar 2011 10:24:54 -0700 (PDT) Date: Tue, 22 Mar 2011 18:01:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 3/7] find_pc_partial_function new parameter Message-ID: <20110322172454.GE2520@adacore.com> References: <20110319211544.GD30867@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110319211544.GD30867@host1.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00998.txt.bz2 > find_pc_partial_function is heavily called inside GDB, therefore I did not > change its prototype and provided find_pc_partial_function_gnu_ifunc instead. > > While I have no problem with changing all the callers it means passing > everywhere the unused additional NULL parameter which may not be a win. I would have used that approach as well. -- Joel