Re: [patch] Fix for PR gdb/12573

Paul Pluzhnikov
2011-03-18T17:02:32Z

On Fri, Mar 18, 2011 at 9:29 AM, Tom Tromey <tromey@redhat.com> wrote:

>>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
>
> Paul> Attached patch fixes http://sourceware.org/bugzilla/show_bug.cgi?id=12573
> Paul> by removing (I believe incorrect) assertion.
>
> See also:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=612253
>
> And Jan's patch:
>
> http://sourceware.org/ml/gdb-patches/2010-07/msg00533.html
>
> I can't say I fully understand Jan's.

The patch looks good to me (and I *think* I understand it).

> It includes yours, though, and comes with a test case.

I was going to include a test case when pinging my patch in a week ;-)

Jan,

Could you reference PR gdb/12573 in your patch, and maybe commit it?

+ /* Place breakpoint only to the first PC in a function, even if some of
+ them are in a lexical sub-block. Put it too all the function
+ instances incl. the inlined ones. */

Suggest:

Put it on all function instances as well, including inlined ones.

Thanks,
--
Paul Pluzhnikov