From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6439 invoked by alias); 16 Mar 2011 17:43:34 -0000 Received: (qmail 6428 invoked by uid 22791); 16 Mar 2011 17:43:33 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Mar 2011 17:43:23 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2GHhLmi026319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 16 Mar 2011 13:43:21 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2GHhJun031666 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Mar 2011 13:43:21 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p2GHhJpu020965; Wed, 16 Mar 2011 18:43:19 +0100 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p2GHhIRl020964; Wed, 16 Mar 2011 18:43:18 +0100 Date: Wed, 16 Mar 2011 17:52:00 -0000 From: Jan Kratochvil To: Paul Pluzhnikov Cc: Tom Tromey , gdb-patches ml , Doug Evans Subject: Re: [patch] Re: Advice on fixing gdb/12528 Message-ID: <20110316174317.GA20882@host1.jankratochvil.net> References: <20110315004140.GA28560@host1.jankratochvil.net> <20110315183650.GA29330@host1.jankratochvil.net> <20110315190304.GA784@host1.jankratochvil.net> <20110315212428.GA21487@host1.jankratochvil.net> <20110316060658.GA10163@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00864.txt.bz2 On Wed, 16 Mar 2011 18:31:50 +0100, Paul Pluzhnikov wrote: > On Tue, Mar 15, 2011 at 11:06 PM, Jan Kratochvil wrote: > I think it's still (slightly) better to print offset to the start of address, > rather than just after it. I agree. > How about this then: > > if (address == 0 && !dwarf2_per_objfile->has_section_at_zero) > { > /* This line table is for a function which has been > GCd by the linker. Ignore it. PR gdb/12528 */ > > long line_offset > = line_ptr - bytes_read - dwarf2_per_objfile->line.buffer; In thise case you can move the line line_ptr += bytes_read; below this block without having to undo the computation here. > > complaint (&symfile_complaints, > _(".debug_line address at offset 0x%lx is 0 " > "[in module %s]"), > line_offset, cu->objfile->name); > p_record_line = noop_record_line; > } But I do not think it matters much to discuss this `complaint' more. Thanks, Jan