From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30125 invoked by alias); 16 Mar 2011 11:44:36 -0000 Received: (qmail 30113 invoked by uid 22791); 16 Mar 2011 11:44:35 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Mar 2011 11:44:31 +0000 Received: (qmail 8721 invoked from network); 16 Mar 2011 11:44:30 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Mar 2011 11:44:30 -0000 From: Pedro Alves To: Joel Brobecker Subject: Re: [PATCH] Add 'getthrds' declaration check in configure for AIX Date: Wed, 16 Mar 2011 13:49:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <1300231553-27938-1-git-send-email-brobecker@adacore.com> <201103160017.45295.pedro@codesourcery.com> <20110316014023.GO31264@adacore.com> In-Reply-To: <20110316014023.GO31264@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103161144.26628.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00839.txt.bz2 On Wednesday 16 March 2011 01:40:23, Joel Brobecker wrote: > > > +# Older versions of AIX do not provide the declaration for the getthrds > > > +# function (it appears that it was introduced with AIX 6.x). > > > +AC_CHECK_DECLS(getthrds, [], [], [[#include ]]) > > > + > > > > Any reason this isn't done close to where we check for AIX > > thread support, and decide to whether to build aix-thread.c in the > > first place? Look for "AiX thread debugging library" further down. > > No specific reason, no. I placed the check there because it seemed > to be the general area where we make cheks of this kind (checks for > library functions, ptrace prototypes, etc). But I'm happy to move > it next to the AIX thread detection check. We could even perform > the check on AIX only, although I had the feeling that we usually > this type of check regardless of the host (this is the case for > the ptrace checks, for instance). I just thought it made sense to keep the aix thread support checks together, and that you might have missed the existing code. If you want to keep them where you were putting them, it's fine with me. (I think the ptrace checks are where they are for both historical reasons, and for the fact that the ptrace support is built by several different hosts (inf-ptrace.c), with slightly different ptrace implentations, and that nobody ever bothered to make them run only on hosts that require them, and that are building the native debugger backend. Library functions used by common code need to be checked in all hosts, of course.) -- Pedro Alves