From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14119 invoked by alias); 15 Mar 2011 19:03:15 -0000 Received: (qmail 14108 invoked by uid 22791); 15 Mar 2011 19:03:14 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_XF,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 19:03:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2FJ38V3015422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 15 Mar 2011 15:03:08 -0400 Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2FJ35aH020616 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 15 Mar 2011 15:03:07 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p2FJ3521001207; Tue, 15 Mar 2011 20:03:05 +0100 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p2FJ345S001206; Tue, 15 Mar 2011 20:03:04 +0100 Date: Tue, 15 Mar 2011 19:18:00 -0000 From: Jan Kratochvil To: Paul Pluzhnikov Cc: Tom Tromey , gdb-patches ml , Doug Evans Subject: Re: [patch] Re: Advice on fixing gdb/12528 Message-ID: <20110315190304.GA784@host1.jankratochvil.net> References: <20110315004140.GA28560@host1.jankratochvil.net> <20110315183650.GA29330@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00810.txt.bz2 On Tue, 15 Mar 2011 19:49:47 +0100, Paul Pluzhnikov wrote: > On Tue, Mar 15, 2011 at 11:36 AM, Jan Kratochvil wrote: > >>        PR gdb/12528 > >>        * gdb.dwarf2/break-on-linker-gcd-function.exp: New test. > >>        * gdb.dwarf2/break-on-linker-gcd-function.cc: New file. > > > > It seems correct to me, please check it in. > > Is location of the test case ok? It is not - it is not the explicit DWARF code, it should be gdb.base/ as you write, thanks. > I also noticed that gdb.dwarf2/Makefile.in would need to have > break-on-linker-gcd-function added to EXECUTABLES (or the executable > renamed to break-on-linker-gcd-function.x). It has been recently fixed by Michael Snyder so it should be maintained now. EXECUTABLES should be updated, I agree. > >> +# This accepts e.g. "Breakpoint 1 at 0x40968a" (fixed GDB) > >> +# but rejects e.g. "Breakpoint 1 at 0x4" (broken GDB). > >> +gdb_test "b [gdb_get_line_number "gdb break here"]" "Breakpoint \[0-9\] at 0x\[0-9a-f\]\[0-9a-f\]+: .*" > > > > I was thinking if some prologue cannot be >=0x10 due to some alignments etc. > > Perhaps "[$hex][$hex][$hex]+" to weed out up to 0xff ? But some embedded targets can fit the whole program / main under 0x100? I would keep it as is, there is only a risk of false PASS, not false FAIL. And the real FAIL would be caught by x86*. Thanks, Jan