Re: [patch] [gdbserver] Fix multi-GB error log files [doc review]

Eli Zaretskii
2011-04-23T11:09:27Z

> Date: Sat, 23 Apr 2011 10:00:23 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> Cc: pedro@codesourcery.com, gdb-patches@sourceware.org, dan@codesourcery.com
>
> On Sat, 23 Apr 2011 08:15:38 +0200, Eli Zaretskii wrote:
> > GDBserver now keeps its listening port open, unless you start
> > GDBserver with the --once option. Keeping the listening port open
> > allows subsequent reconnections from another GDB session.
>
> BTW personally I read it as if GDBserver did not support reconnections before
> and that reconnections are a new feature (which they are not).

Ah, in that case, that's my mistake: I indeed thought the possibility
to reconnect was new. So I guess the right wording of this entry
would be

The new option --once causes GDBserver to stop listening for
connections once the first connection is made. The listening port
used by GDBserver will become available after that.

> > > + Option @option{--multi} is not directly related
> > > +to @kbd{target extended-remote} (therefore @kbd{target remote} is also
> > > +compatible) and vice versa.
> >
> > It's not clear to me how this sentence is related to the surrounding
> > text. What potential problem did you try to prevent by that?
>
> Yes, I was considering to post it as a separate patch but (a) it would be
> a hassle for one sentence and (b) it is all related together anyway.
>
> --multi, remote/extended-remote and --once all together affect when gdbserver
> will / will not terminate. Normally AFAIK one uses either:
> --multi with extended-remote
> or
> (default) with remote
> so I was curious if one can mix the two modes. And to my surprise gdbserver
> behavior in which cases it terminates depends on how GDB connects to it
> (remote/extended-remote) instead of the gdbserver arguments (--multi).
> This is why this question seemed to me logical in the context of explaining
> all the GDB termination rules which needed to be explained together with the
> port allocation rules.

How about this modified text, then?

Note that the conditions under which @code{gdbserver} terminates
depend on how @value{GDBN} connects to it (@kbd{target remote} or
@kbd{target extended-remote}). The @option{--multi} option to
@code{gdbserver} has no influence on that.

> > > +terminated in @kbd{target remote} mode. On the other hand for @kbd{target
> > ^
> > Missing comma there.
>
> You wrote it as "On the other, hand for " but I have used "On the other hand,
> for ", either a typo or a font layout problem on your side.

It's my mistake, sorry. The comma should be after "hand", of course.

> Added @cindex for --once.
>
> Used all your other suggestions, I am not aware much of the commas.
>
> I will check it in if no futher comments appear.

Apart of the above two issues, the new text is fine with me. Thanks.