From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 438 invoked by alias); 15 Mar 2011 17:44:31 -0000 Received: (qmail 427 invoked by uid 22791); 15 Mar 2011 17:44:30 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 17:44:26 +0000 Received: (qmail 23757 invoked from network); 15 Mar 2011 17:44:25 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Mar 2011 17:44:25 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] frame.c (find_frame_sal): Check return value of get_frame_function. Date: Tue, 15 Mar 2011 17:54:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: Joel Brobecker , Michael Snyder References: <4D719288.6050301@vmware.com> <201103151653.54091.pedro@codesourcery.com> <20110315173805.GN31264@adacore.com> In-Reply-To: <20110315173805.GN31264@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201103151744.20297.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00800.txt.bz2 On Tuesday 15 March 2011 17:38:05, Joel Brobecker wrote: > > It would normally, but in this case, we've just found that > > the next frame is an inlined function call. Then it > > certainly has debug info? Otherwise, how would gdb know > > it's an inlined function call? > > Indeed, I think you're right. inline_skipped_symbol shouldn't > be returning a NULL symbol, as far as I can tell. So should > we just add a gdb_assert with a comment explaining why we > expect sym to be non-NULL? I think so. -- Pedro Alves