Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org, Petr Machata <pmachata@redhat.com>
Subject: DWARF sanity checking  [Re: [patch] Fix empty PC range psymtab<->symtab discrepancy]
Date: Tue, 15 Mar 2011 16:16:00 -0000	[thread overview]
Message-ID: <20110315160010.GA19529@host1.jankratochvil.net> (raw)
In-Reply-To: <m3vczk8k1q.fsf@fleche.redhat.com>

On Tue, 15 Mar 2011 16:45:05 +0100, Tom Tromey wrote:
> The patch looks good to me.

Checked in:
	http://sourceware.org/ml/gdb-cvs/2011-03/msg00188.html


> Jan> +	  complaint (&symfile_complaints,
> Jan> +		     _("DW_AT_low_pc %s is not < DW_AT_high_pc %s "
> Jan> +		       "for DIE at 0x%x [in module %s]"),
> Jan> +		     paddress (gdbarch, part_die->lowpc),
> Jan> +		     paddress (gdbarch, part_die->highpc),
> Jan> +		     part_die->offset, cu->objfile->name);
> 
> Thanks for putting this info into the complaint.
> One of my minor wish-list items is that we would do this for all DWARF
> complaints.

While not a GNU project this functionality overlaps with the
pmachata/dwarflint branch of elfutils which should be more complete as the
checks are not just a side-effect.  Unaware how easy would be to port it for
non-ELF DWARF and whether the elfutils GPL exception is good enough for FSF.


Thanks,
Jan


  reply	other threads:[~2011-03-15 16:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14 18:16 [patch] Fix empty PC range psymtab<->symtab discrepancy Jan Kratochvil
2011-03-15 15:51 ` Tom Tromey
2011-03-15 16:16   ` Jan Kratochvil [this message]
2011-03-15 16:26     ` DWARF sanity checking [Re: [patch] Fix empty PC range psymtab<->symtab discrepancy] Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110315160010.GA19529@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmachata@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox