From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79648-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19623 invoked by alias); 15 Mar 2011 00:41:54 -0000
Received: (qmail 19614 invoked by uid 22791); 15 Mar 2011 00:41:53 -0000
X-SWARE-Spam-Status: No, hits=-6.3 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Mar 2011 00:41:46 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2F0fj3f013765	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 14 Mar 2011 20:41:45 -0400
Received: from host1.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p2F0fgsG022919	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Mon, 14 Mar 2011 20:41:44 -0400
Received: from host1.jankratochvil.net (localhost [127.0.0.1])	by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p2F0ffRv014418;	Tue, 15 Mar 2011 01:41:41 +0100
Received: (from jkratoch@localhost)	by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p2F0fe4b014417;	Tue, 15 Mar 2011 01:41:40 +0100
Date: Tue, 15 Mar 2011 03:16:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Tom Tromey <tromey@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>,        Doug Evans <dje@google.com>
Subject: Re: [patch] Re: Advice on fixing gdb/12528
Message-ID: <20110315004140.GA28560@host1.jankratochvil.net>
References: <AANLkTim5vFBo4=mP7-83dqKbmuMAP3ThS6ZW_VN3rjg4@mail.gmail.com> <m3wrk560mf.fsf@fleche.redhat.com> <AANLkTin=U9bE2NoO4abS-qibKMsOCEj+-=G7k=OjXYXf@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AANLkTin=U9bE2NoO4abS-qibKMsOCEj+-=G7k=OjXYXf@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00761.txt.bz2

On Mon, 14 Mar 2011 22:01:44 +0100, Paul Pluzhnikov wrote:
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ testsuite/gdb.cp/pr12528.exp	14 Mar 2011 20:52:11 -0000

I would prefer any non-numeric name of the testfile.


> +set additional_flags {-ffunction-sections -Wl,--gc-sections}
> +if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable \
> +	   [list debug c++ additional_flags=$additional_flags]] != "" } {
> +    untested $srcfile
> +    return -1
> +}

This testfile correctly breaks without the fix applied with:
	g++ (GCC) 4.4.6 20110314 (prerelease)

but it gives false PASS even without the fix applied with:
	g++ (GCC) 4.5.3 20110314 (prerelease)
	g++ (GCC) 4.6.0 20110312 (experimental)

as recent GCCs no longer create multiple ctors in such case.

For a real testcase it should be in gdb.dwarf2/ (and then the special
compilation options are sure no longer needed).


> +if { ![runto_main] } {
> +    fail "Can't run to main"
> +    return
> +}

It could check the `info break' output without running the testcase at all.
Nothing important.



Thanks,
Jan