From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26375 invoked by alias); 14 Mar 2011 12:51:41 -0000 Received: (qmail 26362 invoked by uid 22791); 14 Mar 2011 12:51:40 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 12:51:35 +0000 Received: (qmail 30257 invoked from network); 14 Mar 2011 12:51:34 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2011 12:51:34 -0000 From: Pedro Alves To: Eli Zaretskii Subject: Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011 Date: Mon, 14 Mar 2011 12:59:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: gdb-patches@sourceware.org, pierre.muller@ics-cnrs.unistra.fr References: <20110312015329.GA20179@sourceware.org> <201103141213.43979.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103141251.31400.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00718.txt.bz2 On Monday 14 March 2011 12:34:49, Eli Zaretskii wrote: > > From: Pedro Alves > > Date: Mon, 14 Mar 2011 12:13:43 +0000 > > Cc: "Pierre Muller" > > > > "A function declaration should not have its name in column zero. A > > function definition should have its name in column zero." > > At the very least, please reformat the prototypes like this: > > extern whatever_type foo (type1_t, > type2_t, const char **, foobar_t); > > not like Pierre originally suggested. > > That is, let the left paren and at least one argument be on the same > line as the function name. I'm fine with your suggestion, and in fact it's my preference as well. However, there _are_ cases where you just can't do that, because the return type + function name + parameter end up being too long for a single line. It's even easier to happen when you need to spell out the parameter name, not just the type (to refer to in the describing comment). -- Pedro Alves