From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10630 invoked by alias); 14 Mar 2011 12:13:56 -0000 Received: (qmail 10583 invoked by uid 22791); 14 Mar 2011 12:13:55 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 12:13:50 +0000 Received: (qmail 18258 invoked from network); 14 Mar 2011 12:13:46 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2011 12:13:46 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011 Date: Mon, 14 Mar 2011 12:34:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: "Pierre Muller" References: <20110312015329.GA20179@sourceware.org> <006701cbe220$a1a8dba0$e4fa92e0$@muller@ics-cnrs.unistra.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103141213.43979.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00713.txt.bz2 On Monday 14 March 2011 11:26:40, Eli Zaretskii wrote: > > Would it be better to reformat those as > > extern TYPE long_func_name > > (with_long_parameters); > > instead of > > extern TYPE > > long_func_name (with_long_parameters); > > No, that's even uglier. > But it's what we do all over. We do have the rule that grep "^foofunc" should only match function definitions, not declarations. Here in gdbint.texinfo: "A function declaration should not have its name in column zero. A function definition should have its name in column zero." -- Pedro Alves