From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25426 invoked by alias); 9 Mar 2011 23:58:54 -0000 Received: (qmail 25417 invoked by uid 22791); 9 Mar 2011 23:58:53 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate6.uk.ibm.com (HELO mtagate6.uk.ibm.com) (194.196.100.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 23:58:48 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate6.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p29Nwjeh012712 for ; Wed, 9 Mar 2011 23:58:45 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p29Nx0hA1851502 for ; Wed, 9 Mar 2011 23:59:00 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p29NwjSP018651 for ; Wed, 9 Mar 2011 16:58:45 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p29NwipE018648; Wed, 9 Mar 2011 16:58:44 -0700 Message-Id: <201103092358.p29NwipE018648@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 10 Mar 2011 00:58:44 +0100 Subject: Re: [RFC] Skip hardware breakpoint tests on OpenBSD To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Thu, 10 Mar 2011 04:41:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <201103091629.p29GTPeU019522@glazunov.sibelius.xs4all.nl> from "Mark Kettenis" at Mar 09, 2011 05:29:25 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00625.txt.bz2 Mark Kettenis wrote: > The recently introduced skip_hw_breakpoint_tests procedure is a bit > flawed. It lists hardware platforms that have hardware breakpoints, > but doesn't take into account that the OS running on those platforms > has to make that functionality available to GDB. This isn't the case > on OpenBSD (and perhaps some other operating systems as well). The > diff below makes sure the tests are skipped on OpenBSD. However, > perhaps instead of whitelisting generic hardware platforms, we should > whitelis explicit hardware/OS combinations here? I've just copied the existing tests that were spread throughout various testcases into the new procedure ... That said, I completely agree that this should really be specific to the hardware/OS combinations. The question is what exactly these ought to be. Looking through the config files, it would appear that for the ia64, arm, powerpc and s390 architectures, the only OS supporting watchpoints is Linux. For the x86 architectures, the list gets a lot more complex: i[34567]86-*-go32* i[34567]86-*-msdosdjgpp* i[34567]86-*-cygwin* i[34567]86-*-mingw32* i[34567]86-*-freebsd* i[34567]86-*-kfreebsd*-gnu i[34567]86-*-linux* i[34567]86-*-solaris2.[6789] i[34567]86-*-solaris2.1[0-9] x86_64-*-mingw* x86_64-*-linux* x86_64-*-solaris2.1[0-9]* While I don't really have access to any of those (except Linux) for testing, it probably cannot hurt to replace the generic x86 test with a test for those specific platforms; the worst that could go wrong is that we forgot a platform. B.t.w. it turns out that there are architectures that support watchpoints that haven't been mentioned in the list at all: sparc-*-solaris2.[6789] sparc-*-solaris2.1[0-9] sparcv9-*-solaris2.[6789] sparcv9-*-solaris2.1[0-9] sparc64-*-solaris2.[6789] sparc64-*-solaris2.1[0-9] mips-sgi-irix5* mips-sgi-irix6* mips*-*-linux* Here I'd argue it would be best for someone with access to the platform to add them. Thoughts? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com