From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17906 invoked by alias); 9 Mar 2011 22:14:56 -0000 Received: (qmail 17896 invoked by uid 22791); 9 Mar 2011 22:14:56 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 09 Mar 2011 22:14:52 +0000 Received: (qmail 7671 invoked from network); 9 Mar 2011 22:14:50 -0000 Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Mar 2011 22:14:50 -0000 From: Pedro Alves To: Michael Snyder Subject: Re: [RFA] completer.c (expression_completer): Stop memory leak. Date: Thu, 10 Mar 2011 00:14:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.35-27-generic; KDE/4.6.1; x86_64; ; ) Cc: "gdb-patches@sourceware.org" References: <4D77CDD6.7010700@vmware.com> <201103092007.33388.pedro@codesourcery.com> <4D77E322.6010800@vmware.com> In-Reply-To: <4D77E322.6010800@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201103092214.56400.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00624.txt.bz2 On Wednesday 09 March 2011 20:29:22, Michael Snyder wrote: > OK how is this? Looks completely untested. I'd be most surprised if it didn't crash. Please, please don't have me review untested patches. -- Pedro Alves